Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dynamic master key by setting Parse Server option masterKey to a function #9582

Merged
merged 11 commits into from
Feb 12, 2025

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 1, 2025

Pull Request

Issue

Closes: #9052

Approach

Tasks

  • Add tests

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (4153737) to head (8f4aca8).
Report is 2 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9582   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         186      186           
  Lines       14804    14816   +12     
=======================================
+ Hits        13842    13854   +12     
  Misses        962      962           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/Middlewares.spec.js Outdated Show resolved Hide resolved
@dblythy dblythy requested a review from a team February 3, 2025 09:46
@mtrezza mtrezza changed the title Feat/dynamic master key feat: Add dynamic master key by setting Parse Server option masterKey to a function Feb 3, 2025
src/Options/index.js Outdated Show resolved Hide resolved
mtrezza
mtrezza previously approved these changes Feb 9, 2025
@mtrezza
Copy link
Member

mtrezza commented Feb 9, 2025

The definition check fails

@mtrezza mtrezza merged commit 6f1d161 into parse-community:alpha Feb 12, 2025
24 checks passed
parseplatformorg pushed a commit that referenced this pull request Feb 12, 2025
# [8.0.0-alpha.11](8.0.0-alpha.10...8.0.0-alpha.11) (2025-02-12)

### Features

* Add dynamic master key by setting Parse Server option `masterKey` to a function ([#9582](#9582)) ([6f1d161](6f1d161))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.11

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic master key and maintenance key
3 participants