-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API for date_bin query #1093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsinhaparseable
force-pushed
the
date-bin-fix
branch
from
January 14, 2025 11:42
7640beb
to
3f38a77
Compare
nikhilsinhaparseable
changed the title
init commit for date_bin query improvement
feat: API for date_bin query
Jan 14, 2025
Pull Request Test Coverage Report for Build 12794756596Details
💛 - Coveralls |
Let's work on this after merging #1100? |
de-sh
suggested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider: parmesant#2
de-sh
approved these changes
Jan 15, 2025
Reads manifest files and fetches `num_rows` divides by number of required bins then returns density per bin
avoid datafusion
nikhilsinhaparseable
force-pushed
the
date-bin-fix
branch
from
January 15, 2025 18:29
7d9175b
to
f424aa0
Compare
nikhilsinhaparseable
force-pushed
the
date-bin-fix
branch
from
January 15, 2025 18:31
f424aa0
to
b86e644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new API to get the count(*) for the graph query
API - POST
/datebin
sample request JSON -
{"stream":"frontend", "startTime":"2025-01-08T10:10:00.000Z","endTime":"2026-01-08T23:20:00.000Z", "numBins":10}
sample response JSON -
console sends the number of ticks to show in the graph based on the time range provided by the user
server fetches the stream.json and all manifest.jsons to get the count
avoid datafusion as query demands the count which is available in the catalog
leverage the same flow to get the count(*) queries without filters from query API
eg.
select count(*) from frontend
orselect count(*) as count from frontend