Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename API datebin to counts #1103

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: rename API datebin to counts #1103

merged 4 commits into from
Jan 16, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 16, 2025

Fixes #XXXX.

Description

It makes more sense to call it what it is, an API to figure out the count of logs in a certain time period, at a certain frequency. Previously it was called datebins when it didn't really adhere to the time limits associated with a "date", which is semantically wrong.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12807367262

Details

  • 0 of 34 (0.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 12.775%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/modal/query_server.rs 0 1 0.0%
src/handlers/http/modal/server.rs 0 3 0.0%
src/handlers/http/query.rs 0 13 0.0%
src/query/mod.rs 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/query.rs 1 0.0%
src/handlers/http/modal/server.rs 1 0.0%
Totals Coverage Status
Change from base Build 12802901570: 0.0%
Covered Lines: 2459
Relevant Lines: 19248

💛 - Coveralls

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

nitisht pushed a commit to parseablehq/console that referenced this pull request Jan 16, 2025
This PR moves all the count related graph queries
to the new counts API implemented here
parseablehq/parseable#1103
@nitisht nitisht merged commit 5875a20 into parseablehq:main Jan 16, 2025
6 checks passed
@de-sh de-sh deleted the counts branch January 17, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants