Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use debug_assertions instead of custom feature #1104

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 16, 2025

Fixes #XXXX.

Description

We don't need a custom feature, https://doc.rust-lang.org/reference/conditional-compilation.html#debug_assertions


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh requested a review from nitisht January 16, 2025 11:37
@coveralls
Copy link

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12863585408

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.714%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/mod.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 12855418418: 0.0%
Covered Lines: 2459
Relevant Lines: 19341

💛 - Coveralls

@nitisht
Copy link
Member

nitisht commented Jan 20, 2025

Does this mean the debug section is enabled when building without --release flag?

Also can you confirm we don't need a change in the Dockerfile here: https://github.com/parseablehq/parseable/blob/main/Dockerfile.debug

Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

@nitisht nitisht self-requested a review January 20, 2025 12:30
@@ -23,7 +23,7 @@ LABEL org.opencontainers.image.licenses="AGPL-3.0"

WORKDIR /parseable
COPY . .
RUN cargo build --features debug
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have made that change @nitisht

@nitisht nitisht merged commit cdfe4a0 into parseablehq:main Jan 20, 2025
11 checks passed
@de-sh de-sh deleted the build branch January 20, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants