Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use alpine as base image #1106

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: use alpine as base image #1106

wants to merge 4 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 16, 2025

Fixes #XXXX.

Description

This is just a proposal, the alpine image is only ~40MB smaller on disk

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12852443457

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.714%
Totals Coverage Status
Change from base Build 12850824320: 0.0%
Covered Lines: 2459
Relevant Lines: 19341
💛 - Coveralls

@de-sh
Copy link
Contributor Author

de-sh commented Jan 17, 2025

As can be noticed from the ci runs, alpine is equally suitable base image for parseable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@de-sh @coveralls