Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Google packages #10

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

jryd
Copy link
Contributor

@jryd jryd commented Oct 1, 2018

The package used currently for interacting with Google services has been deprecated in favour of splitting the packages into their respective services.

The older package also has issues on more recent versions of Node (>v6); which has been reported in #8. The updated packages resolve this issue.

I've also updated tutorial.js to use ES6 syntax.

I had to go through the update process to use this in our own project that utilises Particle devices, and figured that I would submit a pull to this in the spirit of #Hacktoberfest.

@rickkas7
Copy link
Contributor

rickkas7 commented Oct 1, 2018

Thank you for making these changes. We're a little busy with our user conference, Spectra, this week but I'll try to test and merge the changes as soon as possible.

@jryd
Copy link
Contributor Author

jryd commented Oct 16, 2018

Have you had a chance to check this out @rickkas7 ? Happy to make any changes if something isn't working.

@rickkas7
Copy link
Contributor

Sorry for the delay. I plan to approve it as is, but for some reason I don't have permissions in this specific repository and I meant to figure out why and forgot. Sorry!

@rickkas7 rickkas7 merged commit 82eaf9f into particle-iot:master Oct 30, 2018
@jryd jryd mentioned this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants