Adds parsing and modeling of CTEs #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds parsing and ast modeling for WITH clause Fixes the expression tree to exclude SELECTs Adds a dedicated subquery node to allow for query expressions
johnedquinn
force-pushed
the
v1-with-clause
branch
from
b9575e4 to
af0995b
Compare
Updates the AST Rewriter for the WITH clause Adds test for the unsupported feature of planning a with clause
johnedquinn
changed the title
jpschorr
reviewed
Feb 6, 2025
jpschorr
reviewed
Feb 6, 2025
| private final List<WithListElement> elements; | ||
|
|
||
| /** | ||
| * TODO |
There was a problem hiding this comment.
Curious when we will 'TODO'? as part of the rest of the CTE work?
| */ | ||
| @Builder(builderClassName = "Builder") | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public final class With extends AstNode { |
There was a problem hiding this comment.
Should there be a helper constructor for With in org.partiql.ast.Ast?
Adds support for parsing RECURSIVE CTEs Adds modeling of RECURSIVE in AST Updates Javadoc TODOs Adds Ast#with and Ast#withListElement Adds a TODO for search/cycle
|
Updated PR to address comments @jpschorr |
jpschorr
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exprBagOpandexprSelectwere at the top of theexprgrammar. This isn't right.exprandselectStatementare distinct variants ofdql.selectStatementis now almost identical to the SQL:1999 and SQL:2023 EBNF. I've noted all of the rules and their origin (and where they deviate). Notably, asimpleTable, in PartiQL, can be an arbitrary expression -- which is not allowed in SQL. This allows for the UNION (and other bag ops) of arbitrary expressions. Note that the visitor prohibits non-bag-ops and non-select expressions coupled with the with clause, order by clause, limit clause, and offset clause.subquery(which is a parenthesized query expression) and the allowance for the direct use of SELECT in a function call (to handle the specification'sCOLL_AGG(SELECT ...)without the use of additional parentheses).API Changes and Release
There are NO API breaking changes. This feature addition will go in the
v1.1.0release.This PR adds
WithandWithListElement. It also adds JoinTypes that allow for LEFT CROSS JOIN, RIGHT CROSS JOIN, FULL CROSS JOIN, and INNER CROSS JOIN. The LEFT CROSS JOIN was already present in the previous implementation. There are parsing conformance tests that also use the remaining.Upcoming Changes
Before the release of
v1.1.0, a follow-up PR will add for planning and evaluation of the WITH clause.License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.