-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ion tests and add null & nan comparisions #543
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (37.85%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
+ Coverage 80.08% 80.12% +0.03%
==========================================
Files 95 95
Lines 20465 20581 +116
Branches 20465 20581 +116
==========================================
+ Hits 16390 16490 +100
- Misses 3640 3648 +8
- Partials 435 443 +8 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5549 Number failing in both: 827 Number passing in Base (f684ea9) but now fail: 0 Number failing in Base (f684ea9) but now pass: 53 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
cc9b35f
to
7028d20
Compare
There are some lingering warnings of the form They are fixed in #544 : for example: https://github.com/partiql/partiql-lang-rust/pull/544/files#diff-b95d0de35899342f30d2531c8cd3728a958d846d163f0c154c204f7aeb8979ceL112 |
95a28d7
to
68f01d4
Compare
7028d20
to
9eab2a3
Compare
9eab2a3
to
d071cf4
Compare
This PR builds on #540 & #542 and adds the ability for comparisons to treat NULLs as equal and/or NaNs as equal.
NaN-equality is mostly of interest for testing against expected examplars.
NULL-equality is used likewise, but also important for compliance with PartiQL's specified semantics for
eqg
.There are still
todo
s and some additional test failures that will be addressed by future PRs that add functionality.To see the ultimate end-point of this integration, refer to #536 and note the test coverage and conformance test results.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.