Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize shots align eigenvectors function #43

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Mar 3, 2025

Solves #25 further by avoiding the for loop.

@chMoussa chMoussa added the enhancement New feature or request label Mar 3, 2025
@chMoussa chMoussa requested a review from RolandMacDoland March 3, 2025 12:49
@chMoussa chMoussa self-assigned this Mar 3, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (2318333) to head (86f5ceb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   91.10%   91.07%   -0.03%     
==========================================
  Files          25       25              
  Lines        1281     1278       -3     
==========================================
- Hits         1167     1164       -3     
  Misses        114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chMoussa looking good. One quick comment.

@chMoussa chMoussa requested a review from RolandMacDoland March 3, 2025 16:24
@chMoussa chMoussa merged commit 53be041 into main Mar 3, 2025
6 checks passed
@chMoussa chMoussa deleted the cm/scan_apply branch March 3, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants