-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add jobs to an open batch #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthieuMoreau0
commented
Feb 1, 2024
18f8b11
to
9169b5f
Compare
Augustinio
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question
[FIX] Return a new batch instance in add_jobs and declare_complete methods. The previous technique of updating the object in place didn't work
MatthieuMoreau0
commented
Feb 8, 2024
MohamedAminMallek
approved these changes
Feb 13, 2024
… warning in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let users add several jobs at once to a batch. I got rid of the previous function which let users add one job to a batch; but this was very inefficient as it required one http call per job. This is technically a breaking change but it couldn't be used by our users since the dedicated endpoint was always returning an error because batches were automatically marked as complete. Hence I think this can be freely released without worrying about breaking existing pipelines for our users.
Changes:
Related PRs in other projects (PASQAL developers only)
Additional merge criteria
Breaking changes
Checklist
Versioning (PASQAL developers only)
_version.py
following the changes in your PR and by using semantic versioning.Documentation
Tests
Internal tests pipeline (PASQAL developers only)
If your PR hasn't changed any functionality, it still needs to be validated against internal tests.
After updating the version (PASQAL developers only)