Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add rebatch feature #111

Merged
merged 20 commits into from
Mar 5, 2024
Merged

[FEAT] Add rebatch feature #111

merged 20 commits into from
Mar 5, 2024

Conversation

Augustinio
Copy link
Collaborator

@Augustinio Augustinio commented Feb 26, 2024

Description

  • Added rebatch for closed batches
  • Added unit tests
  • Added parent_id on batch and job
  • Updated documentation and changelog

Remaining Tasks

  • e2es

Checklist

  • The title of the PR follows the right format: [{Label}] {Short Message}. Label examples: IMPROVEMENT, FIX, REFACTORING... Short message is about what your PR changes.

Versioning (PASQAL developers only)

  • Update the version of pasqal-cloud in _version.py following the changes in your PR and by using semantic versioning.

Documentation

  • Update CHANGELOG.md with a description explaining briefly the changes to the users.

Tests

  • Unit tests have been added or adjusted.
  • Tests were run locally.

Internal tests pipeline (PASQAL developers only)

  • Update and run the internal tests while targeting the branch of this PR.
    If your PR hasn't changed any functionality, it still needs to be validated against internal tests.

After updating the version (PASQAL developers only)

  • Open a PR on the internal tests that updates the version used for the pasqal-cloud backward compatibility tests.

Copy link
Collaborator

@Mildophin Mildophin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me, few non blocking comments

pasqal_cloud/__init__.py Show resolved Hide resolved
pasqal_cloud/__init__.py Show resolved Hide resolved
tests/test_batch.py Show resolved Hide resolved
@awennersteen
Copy link
Member

Nice feature. LGTM

Feature request that might be out of scope:

Could we have a retry argument to the original batch submission?
We have some internal code in quantum libs that could be removed if it was possible to ask for automatic rebatching.

tests/test_batch.py Show resolved Hide resolved
pasqal_cloud/client.py Show resolved Hide resolved
pasqal_cloud/client.py Outdated Show resolved Hide resolved
pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
tests/test_batch.py Show resolved Hide resolved
@Augustinio
Copy link
Collaborator Author

Nice feature. LGTM

Feature request that might be out of scope:

Could we have a retry argument to the original batch submission? We have some internal code in quantum libs that could be removed if it was possible to ask for automatic rebatching.

I think that would definitely be a separate issue/question @MatthieuMoreau0

@Augustinio Augustinio requested a review from oliver-gordon March 4, 2024 12:50
@Augustinio Augustinio merged commit 5c7f270 into dev Mar 5, 2024
5 checks passed
@Augustinio Augustinio deleted the alg/rebatch branch March 5, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants