[Testing] Improve tests on factory tools #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the test case for extract_inputs_variables using the quantum_ast fixture.
RolandMacDoland
changed the title
RolandMacDoland
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Thanks for this @pimvenderbosch. Minor quiblle but more general thought: would it make sense that functions in factory_tools become AST static methods ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory tools module is already pretty well tested by @kaosmicadei. However, I'm adding some extra test cases to increase the coverage.