[Feature] Generic embedding #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
@dominikandreasseitz I would avoid overusing op = getattr(a, b, None)
if op is None:
op = ...is more suitable |
kaosmicadei
reviewed
Jun 28, 2024
| not in instruction_mapping {instruction_mapping} due to {e}." | ||
| ) | ||
|
|
||
| def evaluate(params: dict = dict(), inputs: dict = dict()) -> ArrayLike: |
There was a problem hiding this comment.
What is the story about params and inputs?
Could a single dictionary or a keyword list like def evaluate(**params_and_inputs) -> ArratLike create an issue?
There was a problem hiding this comment.
yeah i agree, essentially for torch it doesnt matter. its just a the legacy-way of how we handled trainable and non-trainable params before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.