Platform backends API and logic structure #17
Conversation
|
@Roland-djee you can review it as well (I cannot add you and Kaonan at the same because of github limitations). Actually, let me know if you want to take over on the review process so you can be more familiar with the platforms logic and structure |
Doomsk
requested review from
RolandMacDoland
and removed request for
kaosmicadei
There was a problem hiding this comment.
Thank you @Doomsk for the amazing work. It would have been a bit better to split into several iterations as it is somewhat difficult to review properly such a big chunk of code. Some comments from me on the first half. I'll review the second half when you've addressed them. Generally, I would strive not to use too much typing types. You use Literal in several places that doesn't have the same guarantees as StrEnum in terms of robustness.
|
Hey @Doomsk is this reviewable/mergeable ? We need to move forward on this for the public release. |
@Roland-djee you mentioned you would split in two parts the review. Changes were made already accounting for your and Pim's suggestions so far. |
Alright, so I'll proceed with the second half of my review and we can move on this. |
There was a problem hiding this comment.
Hey @Doomsk thanks really this is great work. Here are some further comments to this massive PR. Generally, it'd be great to improve on code documentation (doctrings, comments, naming, etc) as the logic is sometimes a bit confusing.
There was a problem hiding this comment.
Hiya @Doomsk @kaosmicadei we're getting there. Main points are to improve docstrings and tests and resolve pending discussions. Thanks !
Closes #7
Add platforms API backends and enables use for
pyqtorchandpulser/qutipbackends and extend it to (user) custom backends.ping @kaosmicadei @jpmoutinho @Roland-djee since there are limited spots for reviewers)