feat(api): added ban record #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nutrina
reviewed
Nov 27, 2024
| last_run_revoke_matching = models.DateTimeField( | ||
| null=True, blank=True, help_text="Last time revoke_matching_credentials was run" | ||
| ) | ||
|
|
There was a problem hiding this comment.
I would include a type field, of type BanType.
That would be much clearer for people to understand, and query for particular ban types (I'm also thinking about analytics, not just eng)
There was a problem hiding this comment.
I'd prefer to restrict it to specific "types" (i.e. field combinations) at the UI level to keep the code simple. But I'm cool with whatever!
…ucing type field in Ban model
added 6 commits
November 29, 2024 17:35
…ions is not successful
added 2 commits
December 2, 2024 11:32
nutrina
reviewed
Dec 3, 2024
| description = models.TextField(default="", null=True, blank=True) | ||
| csv_file = models.FileField( | ||
| max_length=1024, null=False, blank=False, upload_to="revocation_list" | ||
| ) |
There was a problem hiding this comment.
Add help text, what columns are expected?
nutrina
reviewed
Dec 3, 2024
| description = models.TextField(default="", null=True, blank=True) | ||
| csv_file = models.FileField( | ||
| max_length=1024, null=False, blank=False, upload_to="ban_list" | ||
| ) |
There was a problem hiding this comment.
Add help_text, what column sare expected
nutrina
reviewed
Dec 3, 2024
| revocation_list=obj, | ||
| ) | ||
| revocation_item_list.append(db_revocation_item) | ||
| ceramic_cache_list.append(ceramic_cache) |
There was a problem hiding this comment.
Remove ceramic_cache_list variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes passportxyz/passport#3051