Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle different JWT::decode signatures #54

Conversation

stefanorosanelli
Copy link
Contributor

@stefanorosanelli stefanorosanelli commented Mar 20, 2024

This PR provides a solution for #46 caused by different signatures of JWT::decode function in the different supported versions of firebase/php-jwt

This solution has been suggested by @Kreyu in #50

If tests pass and this PR is merged then #51 , #47 and #50 can safely be closed

@stefanorosanelli stefanorosanelli mentioned this pull request Mar 20, 2024
@Kreyu
Copy link

Kreyu commented Mar 20, 2024

@patrickbussmann can you approve the workflow so we can check whether the tests are still failing on this PR?

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (561ae0f) to head (654226d).

❗ Current head 654226d differs from pull request most recent head b9fa8fd. Consider uploading reports for the commit b9fa8fd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #54   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        61        63    +2     
===========================================
  Files              3         3           
  Lines            156       169   +13     
===========================================
+ Hits             156       169   +13     
Files Coverage Δ
src/Token/AppleAccessToken.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@stefanorosanelli
Copy link
Contributor Author

@patrickbussmann should be okay now - workflow actions failed only on coding style, should be fixed now

see https://github.com/patrickbussmann/oauth2-apple/actions/runs/8357382263

@stefanorosanelli
Copy link
Contributor Author

@patrickbussmann if you approve the workflow on the latest commit I bet the tests will pass this time 😉

@stefanorosanelli
Copy link
Contributor Author

Hi @patrickbussmann are you going to merge this PR and publish a new tag/release?
Thanks

@mipapo
Copy link

mipapo commented May 17, 2024

@patrickbussmann Do you need help on this project?

@patrickbussmann
Copy link
Owner

@patrickbussmann Do you need help on this project?

My focus is on other stuff at the moment.
But this PR looks great.

If you want to support: Feel free 👍
Everyone is welcome.

@patrickbussmann patrickbussmann merged commit 74818d3 into patrickbussmann:main May 17, 2024
19 checks passed
@stefanorosanelli stefanorosanelli deleted the fix/jwt-decode-signatures branch May 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants