CompatHelper: bump compat for Trixi to 0.7 for package test, (keep existing compat) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andrewwinters5000
added a commit
that referenced
this pull request
Mar 8, 2024
…ork#18) * add equation SWEWetDry1D * add tests and elixirs * add OrdinaryDiffEq as a test dependency * comment functions related to HR_chen_noelle * fix tests * fix tests #2 * fix tests #3 * fix tests 4 * fix tests 5 * fix tests 6 * add unit tests and namespace conflict test * update unit tests, comment wave speed estimates * update unit test * add compat bounds * add some comments * clean some comments, remove wave speed estimates * comment unused lines * include examples folder for coverage test * add upstream tests * fix ci * Adjust comment * remove comments * do using Trixi instead of using Trixi : Trixi * update swe-1d * add swe-2d * add wet/dry functionality, tests and examples * add unit tests * Update comments in test files * add upstream tests * update comments * fix typos * add Downloads pkg, apply formatter * move downloads dependency to test project.toml * Update Trixi version to 0.7 * fix formatter to older version * add Printf to Project.toml * Change wavespeed estimate to fix tests with hll fluxes * add unit tests, remove unused function * apply formatter * Change comments according to code review, add compat bound for LinearAlgebra * reorganize single test files for each mesh type * Add own flux hll and wave speed estimates; add unit tests * remove unnecessary qualifier * apply formatter * Apply changes from code review and introduce new field equations.swe_trixi * apply formatter * Update name and type assignment of swe_trixi -> basic_swe * add comment about duplication of g and H0 --------- Co-authored-by: Andrew Winters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Trixipackage from0.5, 0.6to0.5, 0.6, 0.7for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.