fix lint issues and some a11y issues

patternfly · Sep 20, 2024 · a200ea2 · a200ea2
1 parent 0c6f33b
commit a200ea2
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 24 deletions.
diff --git a/packages/dev/src/CustomCatalog.tsx b/packages/dev/src/CustomCatalog.tsx
@@ -133,7 +133,7 @@ export const CustomCatalog: React.FC = () => {
         <Content component="p" className="catalog-sub">
           Instructional examples
         </Content>
-        <Gallery hasGutter>
+        <Gallery hasGutter className="pfext-quick-start-catalog__gallery" >
           {allQuickStarts
             .filter((quickStart: QuickStart) => quickStart.metadata.instructional)
             .map((quickStart: QuickStart, index: number) => {
@@ -172,7 +172,7 @@ export const CustomCatalog: React.FC = () => {
         <Content component="p" className="catalog-sub">
           Additional examples
         </Content>
-        <Gallery hasGutter>
+        <Gallery hasGutter className="pfext-quick-start-catalog__gallery" >
           {allQuickStarts
             .filter((quickStart: QuickStart) => !quickStart.metadata.instructional)
             .map((quickStart: QuickStart, index: number) => {

diff --git a/packages/module/release.config.js b/packages/module/release.config.js
@@ -24,5 +24,5 @@ module.exports = {
     '@semantic-release/npm',
   ],
   tagFormat: 'prerelease-v${version}',
-  "dryRun": true,
+  dryRun: true,
 };
diff --git a/packages/module/src/catalog/QuickStartCatalog.tsx b/packages/module/src/catalog/QuickStartCatalog.tsx
@@ -15,7 +15,7 @@ const QuickStartCatalog: React.FC<QuickStartCatalogProps> = ({ quickStarts }) =>
 
   return (
     <div>
-      <Gallery hasGutter>
+      <Gallery hasGutter className="pfext-quick-start-catalog__gallery" >
         {quickStarts.map((quickStart, index) => {
           const {
             metadata: { name: id },

diff --git a/packages/module/src/catalog/QuickStartTile.tsx b/packages/module/src/catalog/QuickStartTile.tsx
@@ -20,7 +20,7 @@ import {
   ButtonProps,
   Flex,
   Stack,
-  Label
+  Label,
 } from '@patternfly/react-core';
 import OutlinedClockIcon from '@patternfly/react-icons/dist/js/icons/outlined-clock-icon';
 import { StatusIcon } from '@console/shared';
@@ -65,7 +65,6 @@ const QuickStartTile: React.FC<QuickStartTileProps> = ({
   const { setActiveQuickStart, footer, getResource } =
     React.useContext<QuickStartContextValues>(QuickStartContext);
 
-
   const statusColorMap = {
     [QuickStartStatus.COMPLETE]: 'green',
     [QuickStartStatus.IN_PROGRESS]: 'purple',
@@ -153,11 +152,7 @@ const QuickStartTile: React.FC<QuickStartTileProps> = ({
         {quickStartIcon}
       </CardHeader>
       <CardTitle>
-        <QuickStartTileHeader
-          name={displayName}
-          onSelect={onSelect}
-          quickStartId={id}
-        />
+        <QuickStartTileHeader name={displayName} onSelect={onSelect} quickStartId={id} />
       </CardTitle>
       <CardBody>
         <Stack hasGutter>
@@ -174,7 +169,7 @@ const QuickStartTile: React.FC<QuickStartTileProps> = ({
             {status !== QuickStartStatus.NOT_STARTED && (
               <Label
                 variant="outline"
-                color={statusColorMap[status] as "green" | "purple" | "grey"}
+                color={statusColorMap[status] as 'green' | 'purple' | 'grey'}
                 icon={<StatusIcon status={status} />}
                 data-test="status"
               >

diff --git a/packages/module/src/catalog/QuickStartTileHeader.tsx b/packages/module/src/catalog/QuickStartTileHeader.tsx
@@ -12,17 +12,14 @@ const QuickStartTileHeader: React.FC<QuickStartTileHeaderProps> = ({
   name,
   quickStartId,
   onSelect,
-}) => {
-
-  return (
-    <Flex flexWrap={{ default: 'nowrap' }}>
-      <Title headingLevel="h3" data-test="title" id={quickStartId}>
-        <Button variant="link" isInline onClick={onSelect}>
-          <QuickStartMarkdownView content={name} />
-        </Button>
-      </Title>
-    </Flex>
-  );
-};
+}) => (
+  <Flex flexWrap={{ default: 'nowrap' }}>
+    <Title headingLevel="h3" data-test="title" id={quickStartId}>
+      <Button variant="link" isInline onClick={onSelect}>
+        <QuickStartMarkdownView content={name} />
+      </Button>
+    </Title>
+  </Flex>
+);
 
 export default QuickStartTileHeader;
diff --git a/packages/module/src/controller/QuickStartFooter.tsx b/packages/module/src/controller/QuickStartFooter.tsx
@@ -76,6 +76,7 @@ const QuickStartFooter: React.FC<QuickStartFooterProps> = ({
     () => (
       <Button
         variant="primary"
+        className="pfext-quick-start-footer__actionbtn"
         onClick={onNext}
         data-testid={`qs-drawer-${camelize(getPrimaryButtonText)}`}
         data-test={`${getPrimaryButtonText} button`}