Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix for title size issue. #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix for title size issue. #351

wants to merge 1 commit into from
+4 −6

Conversation

dlabaj
Copy link
Contributor

@dlabaj dlabaj commented Nov 26, 2024

Fixes issue #342 by removing the extra title tag.

@dlabaj dlabaj self-assigned this Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for quickstarts ready!

Name Link
🔨 Latest commit 39a6b2b
🔍 Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/67453148f9622c0008941470
😎 Deploy Preview https://deploy-preview-351--quickstarts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dlabaj dlabaj linked an issue Nov 26, 2024 that may be closed by this pull request
Card title size doesn't match cards component #342
Open
@dlabaj
fix: Fix for title size issue.
39a6b2b 
fix: removed title.
andrew-ronaldson
andrew-ronaldson reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Titles look good. I noticed the drawer close button should be icon--color--on-brand--default.

Other than that looks good! Thanks Don

kmcfaul
kmcfaul approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Approving if we want to do the close button update in a follow up, or will re-review if this PR is updated

evwilkin
evwilkin approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@evwilkin evwilkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the font size, but calling out that this changes the DOM which could break user tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-ronaldson andrew-ronaldson andrew-ronaldson left review comments

@kmcfaul kmcfaul kmcfaul approved these changes

@evwilkin evwilkin evwilkin approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen Awaiting requested review from nicolethoen

@edonehoo edonehoo Awaiting requested review from edonehoo

Assignees

@dlabaj dlabaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card title size doesn't match cards component
5 participants
@dlabaj @wise-king-sullyman @evwilkin @andrew-ronaldson @kmcfaul