Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc and loo recommendations #1624

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

avehtari
Copy link
Contributor

@avehtari avehtari commented Mar 18, 2024

Small updates to doc. I decided to keep the k_threshold argument default unchanged (0.7), as here it specifically controls for which observations to run moment_matching or reloo, but loo recommendations has a new recommendation if the sample size specific threshold is <0.7 and there are Pareto k's exceeding that threshold. Unfortunately, ps_khat_threshold() is not yet exported in loo or posterior so had to copy that.

EDIT:fixes #1606

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.94%. Comparing base (26a80a4) to head (b7fdca2).

Files Patch % Lines
R/loo.R 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   81.94%   81.94%   -0.01%     
==========================================
  Files          70       70              
  Lines       19951    19956       +5     
==========================================
+ Hits        16348    16352       +4     
- Misses       3603     3604       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paul-buerkner
Copy link
Owner

Thanks! Merging now.

@paul-buerkner paul-buerkner merged commit 332cd55 into paul-buerkner:master Mar 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update readme and messages to take into account latest loo release
3 participants