Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify Like #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahdproduction
Copy link

@ahdproduction ahdproduction commented Apr 28, 2019

Screenshots

CollectionViewiOSHD

Link full video => https://youtu.be/Wdqp5mZCnJ4

What went well?

CollectionView is easy to use and you can easily replace a ListView with a CollectionView without too many problems since most of the properties of a ListView are in the collection, in this PR, I wanted to recreate a Spotify Like with a Horizontal and a Vertical CollectionView, I'm surprised to have all set up pretty quickly !
When selecting an item in the HorizontalView CollectionView, it filters the vertical CollectionView to display the albums of the selected artist.
ScrollToPosition is great, because it's a real problem to make a ScrollToPosition.End in a ListView and besides being able to choose are Snap points, it's great!
The idea of being able to change the color of the selected cell without having to change the style (Android) is an element that was missing, because it means that you can do it at the runtime!
No more having to create Customs Renderers to make multiple cell selection, no more tweaking in the behind code to disable the selection or display a message when the CollectionView is empty and plus being able to put EmptyView different at the runtime, it's really cool.

What didn't go well?

When the application starts in portrait mode and you rotate the device to switch to landscape mode, the CollectionView does not take the full width of the screen even though the HorizontalOption is in FillAndExpand mode, but when you start in landscape mode and switch back to portrait mode all is ok!

I tried to change the color of the SelectedItem, but I couldn't!?

How is the performance?

The loading time is really good, it happens that the CollectionView jerks when scrolling quickly, but I don't know if this is due to the fact that my images are Uri or just because I scroll too quickly!

Question => Do the elements have a Recycling Strategy like ListViews? if so, should it be added or is it active by default?

Missing or Desired Things:

  1. A PullToRequest would be welcome with a custom icon and not native spinners ^^.
  2. I wish we could have put a message also when the elements are loading!
  3. No ItemAppearing event to animate the Cells forced to go through ViewCell (so less efficient)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant