Add '-progress' option. Closes #30

[entrity]

Pursuant to #30, this commit adds a '-progress' option. If set to true, then a function pointer is passed to 'fillwithbytes', with the result that each iteration of the loop in that function outputs a progress update.

The progress update appears at the end of the current line and overwrites itself with each repetition, producing an output resembling the following:

Now eliminating candidates based on [...]: (16/19324)

[valerio-bozzolan]

Thanks for this work. Have you already seen this instead? Any comment? (was proposed 4 years ago)

#42

[entrity]

Thanks for this work. Have you already seen this instead? Any comment? (was proposed 4 years ago)

#42

Hi, @valerio-bozzolan . I've just given it a look. The differences I see are:

• Added a -progress option to display the progress during elimination #42 passes a stream pointer; this pull-request passes a function pointer. I prefer this pull-request's implementation because the presenter logic is abstracted out of Rdutil::fillwithbytes and more easily replaced if someone wants a different format in the future
• Added a -progress option to display the progress during elimination #42 outputs progress as a percentage; this pull requests outputs progress as count / total. I prefer this pull-request's implementation because, as one of the comments on 42 points out, it can take a long time to see any update on 42 if the job is very large.
• Added a -progress option to display the progress during elimination #42 updates its output only once every 10k iterations; this pull-request updates its output every iteration. This one's a toss-up. I like the more frequent updates, but another user might prefer not to spend cycles on such frequent updates.
• Added a -progress option to display the progress during elimination #42 uses a carriage return \r to update the entire line; this pull-request saves the cursor location and just updates the numbers at the end of the line, i.e. the parenthetical in Now eliminating candidates based on [...]: (16/19324).

[entrity]

👋 Hello, maintainers. Is there anything I can do to get this pull request promoted/merged? Or is there any feedback regarding changes you'd like?