This should never happen FIXME! solution for macOS #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate the attempt to improve the error message but I don't agree on the solution since it assumes that the user is using the proprietary macOS operating system. Instead, if should just says that permissions are denied (e.g. in "normal" :D systems you may try to run "sudo" I guess). Relevant discussion: #32 |
|
There is conditional compilation applied to that part
…On Mon, Dec 16, 2024 at 9:59 AM Valerio Bozzolan ***@***.***> wrote:
I appreciate the attempt to improve the error message but I don't agree on
the solution since it assumes that the user is using the proprietary macOS
operating system. Instead, if should just says that permissions are denied
(e.g. in "normal" :D systems you may try to run "sudo" I guess).
Relevant discussion: #32 <#32>
—
Reply to this email directly, view it on GitHub
<#166 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZLE7LEBFUNGUK6VUBGBF32F3TGZAVCNFSM6AAAAABTQNYIZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBVHA2TIOBYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Got it. Seems good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting these errors on macOS
I looked into them and discovered the root cause in my case was lack of Full Disk Access permissions given to my terminal app, so I added some code to both better explain the error in general in all cases, and suggest the solution in this particular macOS case (where opendir() is returning EPERM, when compiled for macOS)