MDL-84267 mod_data: deprecate unused comment related capabilities.

They were replaced with core comment API in, and have been unused since, both 4311073 & e998eff.
paulholden · Jan 21, 2025 · a2e8872 · a2e8872
1 parent a2653cc
commit a2e8872
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 51 deletions.
diff --git a/.upgradenotes/MDL-84267-2025012110222203.yml b/.upgradenotes/MDL-84267-2025012110222203.yml
@@ -0,0 +1,9 @@
+issueNumber: MDL-84267
+notes:
+  mod_data:
+    - message: |-
+        The following unused capabilities have been deprecated:
+
+        * `mod/data:comment`
+        * `mod/data:managecomments`
+      type: deprecated
diff --git a/backup/cc/sheets/moodle_blti_export.xml b/backup/cc/sheets/moodle_blti_export.xml
@@ -847,18 +847,6 @@
           <TIMEMODIFIED>1311692131</TIMEMODIFIED>
           <MODIFIERID>0</MODIFIERID>
         </CAPABILITY>
-        <CAPABILITY>
-          <NAME>mod/data:managecomments</NAME>
-          <PERMISSION>1</PERMISSION>
-          <TIMEMODIFIED>1311692131</TIMEMODIFIED>
-          <MODIFIERID>0</MODIFIERID>
-        </CAPABILITY>
-        <CAPABILITY>
-          <NAME>mod/data:comment</NAME>
-          <PERMISSION>1</PERMISSION>
-          <TIMEMODIFIED>1311692131</TIMEMODIFIED>
-          <MODIFIERID>0</MODIFIERID>
-        </CAPABILITY>
         <CAPABILITY>
           <NAME>mod/data:approve</NAME>
           <PERMISSION>1</PERMISSION>
@@ -1244,12 +1232,6 @@
           <TIMEMODIFIED>1311692130</TIMEMODIFIED>
           <MODIFIERID>0</MODIFIERID>
         </CAPABILITY>
-        <CAPABILITY>
-          <NAME>mod/data:comment</NAME>
-          <PERMISSION>1</PERMISSION>
-          <TIMEMODIFIED>1311692130</TIMEMODIFIED>
-          <MODIFIERID>0</MODIFIERID>
-        </CAPABILITY>
         <CAPABILITY>
           <NAME>mod/choice:choose</NAME>
           <PERMISSION>1</PERMISSION>

diff --git a/mod/data/db/access.php b/mod/data/db/access.php
@@ -66,20 +66,6 @@
         )
     ),
 
-    'mod/data:comment' => array(
-
-        'riskbitmask' => RISK_SPAM,
-
-        'captype' => 'write',
-        'contextlevel' => CONTEXT_MODULE,
-        'archetypes' => array(
-            'student' => CAP_ALLOW,
-            'teacher' => CAP_ALLOW,
-            'editingteacher' => CAP_ALLOW,
-            'manager' => CAP_ALLOW
-        )
-    ),
-
     'mod/data:rate' => array(
 
         'captype' => 'write',
@@ -154,19 +140,6 @@
         )
     ),
 
-    'mod/data:managecomments' => array(
-
-        'riskbitmask' => RISK_SPAM,
-
-        'captype' => 'write',
-        'contextlevel' => CONTEXT_MODULE,
-        'archetypes' => array(
-            'teacher' => CAP_ALLOW,
-            'editingteacher' => CAP_ALLOW,
-            'manager' => CAP_ALLOW
-        )
-    ),
-
     'mod/data:managetemplates' => array(
 
         'riskbitmask' => RISK_SPAM | RISK_XSS,
@@ -265,4 +238,7 @@
     )
 );
 
-
+$deprecatedcapabilities = [
+    'mod/data:comment' => ['message' => 'This capability should not be used anymore.'],
+    'mod/data:managecomments' => ['message' => 'This capability should not be used anymore.'],
+];
diff --git a/mod/data/lang/en/data.php b/mod/data/lang/en/data.php
@@ -88,12 +88,10 @@
 $string['csvwithselecteddelimiter'] = '<abbr title="Comma Separated Values">CSV</abbr>';
 $string['data:addinstance'] = 'Add a new database';
 $string['data:approve'] = 'Approve and undo approved entries';
-$string['data:comment'] = 'Write comments';
 $string['data:exportallentries'] = 'Export all database entries';
 $string['data:exportentry'] = 'Export a database entry';
 $string['data:exportownentry'] = 'Export own database entry';
 $string['data:exportuserinfo'] = 'Export user information';
-$string['data:managecomments'] = 'Manage comments';
 $string['data:manageentries'] = 'Manage entries';
 $string['data:managetemplates'] = 'Manage templates';
 $string['data:manageuserpresets'] = 'Manage presets';
@@ -479,7 +477,9 @@
 // Deprecated since Moodle 4.3.
 $string['completionentries'] = 'Require entries';
 
-// Deprecated since Moodle 4.4.
-
 // Deprecated since Moodle 4.5.
 $string['tagsdeleted'] = 'Database tags have been deleted';
+
+// Deprecated since Moodle 5.0.
+$string['data:comment'] = 'Write comments';
+$string['data:managecomments'] = 'Manage comments';
diff --git a/mod/data/lang/en/deprecated.txt b/mod/data/lang/en/deprecated.txt
@@ -1,3 +1,5 @@
 fieldids,mod_data
 completionentries,mod_data
 tagsdeleted,mod_data
+data:comment,mod_data
+data:managecomments,mod_data
diff --git a/mod/data/version.php b/mod/data/version.php
@@ -24,7 +24,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2024121800;       // The current module version (Date: YYYYMMDDXX).
+$plugin->version   = 2025012100;       // The current module version (Date: YYYYMMDDXX).
 $plugin->requires  = 2024100100;       // Requires this Moodle version.
 $plugin->component = 'mod_data';       // Full name of the plugin (used for diagnostics)
 $plugin->cron      = 0;