Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace czlib with go-libdeflate #55

Closed
wants to merge 6 commits into from
Closed

replace czlib with go-libdeflate #55

wants to merge 6 commits into from

Conversation

paulmach
Copy link
Owner

merged #50 into here so I could fix the errors. See that PR for more details.

I was unable to run this locally, so sort of linker issues. Will need to debug.

@oflebbe
Copy link
Contributor

oflebbe commented Dec 29, 2023

I can reproduce the issue and asking myself what is going on, since I am pretty sure it worked flawless on my mac before.
I am a bit short of time the now, will update the PR when I am back.

@OlafFlebbeBosch
Copy link

Ah ok, the linking issue is not present on intel macos.

@oflebbe
Copy link
Contributor

oflebbe commented Dec 29, 2023

Ok will retract. There are serious issues with go-deflate: https://github.com/4kills/go-libdeflate/tree/master/v2/native/libs does not contain darwin/arm64 , the libs included can not to be compatible to both musl and glibc based systems. IMO a an questionale approach to bundle binary libs.

@paulmach
Copy link
Owner Author

paulmach commented Jan 8, 2024

I will close. If this comes up we could allow people to provide their own implementations via some sort of Decode(out, in []byte) error. But I personally don't think decode performance is a bottleneck is "real" usage.

@paulmach paulmach closed this Jan 8, 2024
@paulmach paulmach deleted the deflate branch January 8, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants