fixed rotator for z-up vectors

pavelsevecek · Jul 5, 2020 · 4ff932e · 4ff932e
1 parent 2118cff
commit 4ff932e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Matrix.hpp b/Matrix.hpp
@@ -317,9 +317,10 @@ inline Mat33f getRotationMatrix(const Vec3f& axis, const float angle) {
 
 // (0,0,1) -> dir rotator
 inline Mat33f getRotatorTo(const Vec3f& dir) {
-    const Vec3f up(0, 0, 1);
-    if (dir == up) {
-        return Mat33f::identity();
+    Vec3f up(0, 0, 1);
+    const float dot = dotProd(dir, up);
+    if (fabs(dot) > 0.999999f) {
+        up = Vec3f(1, 0, 0);
     }
 
     const Vec3f x = normalize(crossProd(up, dir));

diff --git a/UniformGrid.hpp b/UniformGrid.hpp
@@ -57,7 +57,8 @@ class UniformGrid {
     Idxs dims_;
 
 public:
-    UniformGrid() = default;
+    UniformGrid()
+        : dims_(0) {}
 
     UniformGrid(const Idxs& dims)
         : dims_(dims) {