Pass image instead of path and height

[JoshuaLampert]

Thanks for the template! I wanted to try the recently added feature of adding an image (thanks @Orbion-J!), but struggled with including the image. It seems like typst searches for the image in the directory of moderner-cv, instead of the directory of the project, which uses moderner-cv. I get the following error:

error: file not found (searched at /home/lampert/.cache/typst/packages/preview/moderner-cv/0.1.2/picture.jpg)
   ┌─ @preview/moderner-cv:0.1.2/lib.typ:78:22
   │
78 │     let image = image(image-path, height: image-height)
   │                       ^^^^^^^^^^

Obviously, I don't want to put my image into this specific path, but rather in my project dir. Therefore, I propose to pass an image object instead of only the path. This also makes the image-height parameter obsolete as it is passed to the image function, which the user is now supposed to call.
What do you think?

[pavelzw]

sounds good to me, any other opinions @Orbion-J?

[JoshuaLampert]

Should we continue with this if @Orbion-J doesn't answer?

[Orbion-J]

hey, sorry I did not answer sooner. That's actually a better idea to give an image object I think, thank you for that.
To avoid the error you had, you need to give a path that starts with / so that it searches at the root of the project and not in the template folder.

[JoshuaLampert]

That's what I tried and gave me the error above.

[JoshuaLampert]

Here is an MWE: https://typst.app/project/rW8SSglf9kWEOikQNLIR3r

[Orbion-J]

Oh I see, that is a bit strange to me. Using a local import, I don't have such issue but with the @preview import it breaks yes. I'll try to understand what is going on and if a fix is possible.
But anyway, as I said, I think using image objects is better anyway so if this fixes this issue, let's go for it

[JoshuaLampert]

Yes, I agree. If you are fine with it, let's just go with passing an image. Thanks for having a look @Orbion-J.

[pavelzw]

Great! I'll create a release after taking a look at #14

[JoshuaLampert]

Thanks!