Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional image #9

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Add optional image #9

merged 6 commits into from
Jan 22, 2025

Conversation

Orbion-J
Copy link
Contributor

@Orbion-J Orbion-J commented Jan 19, 2025

The LaTeX package moderncv allows to have a framed imaged on the right hand side of the header. This PR introduces this possibility in this template.

One can specify a path for the image, its height (by defaut 8em) and its frame (by default 1pt + the color).

The frame can be set to none and completely removed or set to any stroke value. If the color is not specified, the main color of the template will be used.

@Orbion-J Orbion-J requested a review from pavelzw as a code owner January 19, 2025 20:59
Copy link
Owner

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you take care of the failing ci by formatting your changes using typstfmt?

also, could you add this feature to README.md as well?

Orbion-J and others added 3 commits January 22, 2025 14:13
@pavelzw
Copy link
Owner

pavelzw commented Jan 22, 2025

Could you also update the repo to the latest main version?

@Orbion-J
Copy link
Contributor Author

sorry this was my first PRs so I am not much accustomed to the good practices and conventions. Thanks for accepting my work into your project

@pavelzw pavelzw changed the title Add an image Add optional image Jan 22, 2025
@pavelzw pavelzw added the enhancement New feature or request label Jan 22, 2025
@pavelzw pavelzw merged commit 3b4e618 into pavelzw:main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants