Remove unnecessary '> 0', and mark parameters as optional. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thank you fantastic contribution. Thing that you picked up seems to be a bug at the first glance to me. I will do a tiny test and merge you PR soon. I will avoid this kind of bugs in the future because I am working on TypeScript'ifing the whole project in next release. I am not experienced TypeScript'er but I can't wait for this change. Can't thank you enough Daniel. |
sqwk
added a commit
to sqwk/siema
that referenced
this pull request
Nov 13, 2019
Mirrors pull request pawelgrzybek#158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I work on the TypeScript team and was curious to see how well TypeScript's JS-type-checking mode would work on your project since it makes pretty good use of JSDoc type annotations.
In the process I found what I believe is either an unnecessary check, or a potential bug. I figured it'd be worthwhile to send a PR upstream and consult with you.
I also made some documentation-related edits to mark several
callbackparameters as optional. While not strictly necessary, it couldn't hurt future contributors.Hope you find this helpful!