improve detection when dragged element is a link #167
Conversation
|
|
||
| let target = e.target | ||
| do { | ||
| if (target.nodeName === 'A') { |
There was a problem hiding this comment.
I've suggest to use nodeName.toLowerCase() and compare with a. You never know what case will be returns (IE eg)
There was a problem hiding this comment.
Good point :) I promise to come here and merge all relevant PRs. One day. To be honest I do not care about Siema that much anymore...
There was a problem hiding this comment.
Maybe I can be a maintainer? SIEMA is so awesome for me 😄
There was a problem hiding this comment.
Can we do a Skype chat one day or catch up in Warsaw about it? Short answer - yes :)
There was a problem hiding this comment.
UX issues aside, was there an update on this? Unfortunately, some of us still end up having to build carousels!
There was a problem hiding this comment.
How can i edit siema.js from src, and be able to use it?
The unminified siema doesnt work, only min.js
So i cant use your changes, and i really need to try that
I want to compile a new siema with your modification, im using v1.51 but have the link-open-bug when sliding link content
How can i edit siema.js from src, and be able to use it? The unminified siema doesnt work, only min.js So i cant use your changes, and i really need to try that I want to compile a new siema with your modification, im using v1.51 but have the link-open-bug when sliding link content |
|
Hi. Try to fetch this repo and build it yourself with |
I have a few cases where the A tag detection is not working. It is usually a SPAN or P tag within the A tag that is the event target. This PR looks up the dom tree to find an A tag, and fixes the issue.