Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Convert Project to Typescript #259

Closed
wants to merge 4 commits into from

Conversation

BatuhanW
Copy link

@BatuhanW BatuhanW commented Jan 2, 2020

Unlike Refactor Typescript PR, this PR converts project to Typescript, instead of just adding d.ts file.

@BatuhanW BatuhanW changed the title Convert Project to Typescript WIP: Convert Project to Typescript Jan 2, 2020
@tan-ahmed
Copy link

this project isnt being maintained anymore why don't you just fork and take over ?

@pawelgrzybek
Copy link
Owner

As I mentioned, I will updated it soon. Rewrite to TS is definite part of new release. Stay tuned.

@pawelgrzybek
Copy link
Owner

Is this PR still WIP or ready to review?

@BatuhanW
Copy link
Author

Still WIP, but I could get some early review @pawelgrzybek

@sqwk
Copy link

sqwk commented Jan 14, 2020

@BatuhanW Regarding #256 : That PR has in fact been fully converted to TS and types are being created automatically through the build process. I think you might have looked at the resulting JS file and not at src/siema.ts

EDIT: Also just updated to use ESlint.

@BatuhanW
Copy link
Author

Since the work is already completed on #256, I'm closing this one.

@BatuhanW BatuhanW closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants