Do not reload carousel on scroll down on mobile devices #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address bar is hidden on scroll down on most mobile devices, which triggers a resize event. However Siema does not rely on height, hence the resize event should be ignored to avoid recreating the DOM for nothing. This is important for any carousel that relies on DOM construction (ex: videos)
|
Yeah, I have no intention to maintain this repo, but I really appreciate your contribution here @JulienPradet ! I may merge this one and few other upvoted PRs and release a minor release at some point, so I am glad that you opened this PR. Have a fab day 🫶 |
Lemon2311
approved these changes
Dec 17, 2023
marceloberwanger
added a commit
to marceloberwanger/siema
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address bar is hidden on scroll down on most mobile devices, which triggers a resize event. However Siema does not rely on height, hence the resize event should be ignored to avoid recreating the DOM for nothing.
This is important for any carousel that relies on DOM construction (ex: videos).
I'm aware that the repo is not actively maintained, but sending this PR in case in can still be of help to others.