FISH-6287 Payara6 concurrency 3.0 upgrade #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-upgrade Fish-5962: adding samples to test concurrency 3.0
Signed-off-by: Petr Aubrecht <[email protected]>
…nous Fish 5963 concurrency add @asynchronous
…executor-annotation Fish-6037: support managedexecutor annotation
…executor-xml-tag Fish-6037: support managedexecutor xml tag
The whole class is pushed to the CDI extension, but only some methods can be annotated. This change skips all the others.
Missing parts: multiple values, propagation of values, custom context services
…t during jndi lookup This change returns the previous behavior, thread context is saved during invocation of a thread.
…ency3 Fish 6287 merge payara6 to concurrency3
Fish 6287 fix ManagedThreadFactory's saving context, around newThread()
…yara6 Fish 6287 merge concurrency3 to payara6
Pandrex247
changed the title
Pandrex247
reviewed
May 24, 2022
...concurrent-connector/src/main/java/org/glassfish/concurrent/config/ManagedThreadFactory.java
Show resolved
Hide resolved
...rent-connector/src/main/java/org/glassfish/concurrent/config/ManagedExecutorServiceBase.java
Show resolved
Hide resolved
...urrent/concurrent-impl/src/main/java/org/glassfish/concurrent/runtime/InvocationContext.java
Show resolved
Hide resolved
...urrent-impl/src/main/java/org/glassfish/concurrent/runtime/TransactionSetupProviderImpl.java
Show resolved
Hide resolved
appserver/ejb/ejb-container/src/main/java/org/glassfish/ejb/deployment/node/EjbNode.java
Show resolved
Hide resolved
| @@ -64,7 +64,7 @@ | |||
| <module>jaxrs-rolesallowed</module> | |||
| <module>jaxrs-rolesallowed-servlet</module> | |||
| <module>jaxws-security</module> | |||
| <module>jaxws-tracing</module> | |||
| <!--module>jaxws-tracing</module--> | |||
There was a problem hiding this comment.
Are we commenting these out to pass Jenkins?
appserver/web/web-glue/src/main/java/org/glassfish/web/deployment/node/WebCommonNode.java
Show resolved
Hide resolved
nucleus/resources/src/main/java/org/glassfish/resourcebase/resources/api/ResourceConstants.java
Show resolved
Hide resolved
...sources/src/main/java/org/glassfish/resourcebase/resources/naming/ResourceNamingService.java
Show resolved
Hide resolved
Pandrex247
reviewed
May 24, 2022
.../common/container-common/src/main/java/org/glassfish/javaee/services/JndiLookupNotifier.java
Show resolved
Hide resolved
Pandrex247
reviewed
May 24, 2022
...rent-connector/src/main/java/org/glassfish/concurrent/config/ManagedExecutorServiceBase.java
Show resolved
Hide resolved
Pandrex247
reviewed
May 24, 2022
...concurrent-connector/src/main/java/org/glassfish/concurrent/config/ManagedThreadFactory.java
Show resolved
Hide resolved
Pandrex247
reviewed
May 24, 2022
Pandrex247
reviewed
May 24, 2022
| * only if the new code is made subject to such option by the copyright | ||
| * holder. | ||
| */ | ||
| package org.glassfish.javaee.services; |
There was a problem hiding this comment.
Does this actually need to be in a org.glassfish.javaee package?
Could it a) not be fish.payara and b) not be jakartaee (or just ee)?
Pandrex247
reviewed
May 24, 2022
...rrent/concurrent-impl/src/main/java/org/glassfish/concurrent/cdi/ConcurrentCDIExtension.java
Outdated
Show resolved
Hide resolved
Pandrex247
reviewed
May 24, 2022
...rrent/concurrent-impl/src/main/java/org/glassfish/concurrent/cdi/ConcurrentCDIExtension.java
Outdated
Show resolved
Hide resolved
Pandrex247
reviewed
May 25, 2022
...concurrent-impl/src/main/java/org/glassfish/concurrent/runtime/ContextSetupProviderImpl.java
Outdated
Show resolved
Hide resolved
Pandrex247
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Concurrency 3.0.0 implementation
Testing
Testing Performed
TCK runs clearly, runner is here: https://github.com/payara/jakartaee-10-tck-runners together with docs.
Testing Environment
Linux, OpenJDK 11