bugfix: Split CDI bean deployment when multiple WARs exist in an EAR #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pandrex247 Do you think you can run the TCK against this PR? Thank you! |
lprimak
changed the title
|
@lprimak I ran it through the CDI and EJB TCKs and all seems green 👍 |
|
Thanks, Fantastic! |
lprimak
commented
Oct 28, 2024
appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java
Outdated
Show resolved
Hide resolved
…I-enabled library JARs
lprimak
force-pushed
the
cdi-ear-exception
branch
from
1c8a517
to
93071cf
Compare
|
I have found a few issues that I found with "real" applications. |
|
I may also roll a fix for #6405 if that's trivial as well |
- de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - made some structures final (cleanup)
lprimak
force-pushed
the
cdi-ear-exception
branch
from
a00f107
to
4c255ef
Compare
lprimak
force-pushed
the
cdi-ear-exception
branch
from
89ef769
to
4a79348
Compare
|
Im getting close. "Real" application runs. |
lprimak
force-pushed
the
cdi-ear-exception
branch
from
61c4079
to
2471951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix. BeanManager isn't properly retrieved when multiple CDI WARs exist in an EAR.
fixes #7031
also fixes #7078
Appears specifically when multiple WARs use OmniFaces
Important Info
** Works and tests pass, but needs more testing to see if all the issues are actually fixed **
Testing
Tested with the failing reproducer
** Needs TCK run
Needs testing with a realistic EAR application, which is still TODO