Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating mergo.Merge() to version passing override functions #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

spellgen
Copy link

I started building an sdk myself, based on crypt because mod rewrite was broken on my target system.
Now that that back-end is fixed I'd rather use the published API paths and am happy to have found your package.
I noticed that you had pinned it to an old version of mergo - offering a small PR to update your call to their current format for mergo.Merge() - see below.
I used dep to build the vendor tree but decided against submitting them in the PR and they are in the .gitignore as you can see.
Hopefully this is helpful to you, if not I'll just keep my fork and potentially add controller access as I'll need them.

Cheers, and thanks for sharing this in the first place.

-Stefan Engstrom (ENA)

@spellgen
Copy link
Author

Another need for my use is the ability to specify an http client (that can be shared and re-used) - in my case I discover the ipam host as a raw host (specified by ip address) so I need to pass a Transport that skips cert verification.

I have implemented this by adding an http.Client to the Session object. It has a lock to protect against the use case where more than one go-routines are making calls off the same session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant