updating mergo.Merge() to version passing override functions #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started building an sdk myself, based on crypt because mod rewrite was broken on my target system.
Now that that back-end is fixed I'd rather use the published API paths and am happy to have found your package.
I noticed that you had pinned it to an old version of mergo - offering a small PR to update your call to their current format for mergo.Merge() - see below.
I used dep to build the vendor tree but decided against submitting them in the PR and they are in the .gitignore as you can see.
Hopefully this is helpful to you, if not I'll just keep my fork and potentially add controller access as I'll need them.
Cheers, and thanks for sharing this in the first place.
-Stefan Engstrom (ENA)