Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement delete account functionality #403

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Conversation

Adebisi1234
Copy link
Contributor

@Adebisi1234 Adebisi1234 commented Jan 26, 2025

I've implemented delete account route
Also written test for the route

I couldn't test the code locally because I couldn't get the container running with postgres

I'll appreciate your review of the code and testing.

closes #366

controllers/accounts/auth.go Outdated Show resolved Hide resolved
controllers/accounts/auth_test.go Outdated Show resolved Hide resolved
controllers/accounts/auth_test.go Outdated Show resolved Hide resolved
controllers/accounts/auth_test.go Show resolved Hide resolved
Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

thanks for raising your first PR... can you resolve this failing test ^

@Adebisi1234
Copy link
Contributor Author

Yes, I'll ensure I resolve every issue before the end of today

@Adebisi1234
Copy link
Contributor Author

@OnahProsperity can you please review my changes

I've address all raised issues

Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adebisi1234 can you resolve the failing tests

  • try running the tests locally to ensure they pass before pushing

you can install ganache and run a local blockchain with HD_WALLET_MNEMONIC="media nerve fog identify typical physical aspect doll bar fossil frost because"; ganache -m "$HD_WALLET_MNEMONIC" --chain.chainId 1337 -l 21000000

then run the tests with go tests -v ./...

@paycrest paycrest deleted a comment from OnahProsperity Jan 29, 2025
@Adebisi1234
Copy link
Contributor Author

@chibie thanks I've been able to resolve all failing test.

Couldn't run the test cases previously because spinning up the docker image keeps failing while connecting to postgres

@Adebisi1234
Copy link
Contributor Author

@chibie are there still some changes I need to implement? Or why is the pr not being merged

The failing test case isn't from my implementation

@chibie
Copy link
Contributor

chibie commented Feb 5, 2025

@chibie are there still some changes I need to implement? Or why is the pr not being merged

The failing test case isn't from my implementation

no, it isn't from your changes.. your pr will be merged soon @Adebisi1234

chibie
chibie previously approved these changes Feb 5, 2025
@chibie chibie requested a review from OnahProsperity February 5, 2025 02:19
@chibie chibie dismissed OnahProsperity’s stale review February 5, 2025 02:19

already implemented

@chibie chibie merged commit 05d9db9 into paycrest:main Feb 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add User Account Deletion Endpoint
3 participants