feat: added cancellation reasons #406
Open
+203
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: superman <[email protected]>
Signed-off-by: od-hunter <[email protected]>
|
The PR message doesn't have any details. Update the PR template for |
Done |
chibie
requested changes
Jan 30, 2025
There was a problem hiding this comment.
can you resolve these failing tests?
- try running the tests locally to ensure they pass before pushing
you can install ganache and run a local blockchain with HD_WALLET_MNEMONIC="media nerve fog identify typical physical aspect doll bar fossil frost because"; ganache -m "$HD_WALLET_MNEMONIC" --chain.chainId 1337 -l 21000000
then run the tests with go tests -v ./...
chibie
reviewed
Feb 3, 2025
Comment on lines
186
to
226
| // t.Run("fetch orders with cancellation reasons", func(t *testing.T) { | ||
| // // Create a test order with cancellation reasons | ||
| // order, err := test.CreateTestLockPaymentOrder(map[string]interface{}{ | ||
| // "gateway_id": uuid.New().String(), | ||
| // "provider": testCtx.provider, | ||
| // "cancellation_reasons": []string{"Out of stock", "Payment failed"}, | ||
| // }) | ||
| // assert.NoError(t, err) | ||
|
|
||
| // var payload = map[string]interface{}{ | ||
| // "timestamp": time.Now().Unix(), | ||
| // } | ||
|
|
||
| // signature := token.GenerateHMACSignature(payload, testCtx.apiKeySecret) | ||
|
|
||
| // headers := map[string]string{ | ||
| // "Authorization": "HMAC " + testCtx.apiKey.ID.String() + ":" + signature, | ||
| // "Client-Type": "backend", | ||
| // } | ||
|
|
||
| // res, err := test.PerformRequest(t, "GET", fmt.Sprintf("/orders?timestamp=%v", payload["timestamp"]), nil, headers, router) | ||
| // assert.NoError(t, err) | ||
|
|
||
| // // Assert the response body | ||
| // assert.Equal(t, http.StatusOK, res.Code) | ||
|
|
||
| // var response types.Response | ||
| // err = json.Unmarshal(res.Body.Bytes(), &response) | ||
| // assert.NoError(t, err) | ||
| // assert.Equal(t, "Orders successfully retrieved", response.Message) | ||
|
|
||
| // data, ok := response.Data.(map[string]interface{}) | ||
| // assert.True(t, ok, "response.Data is not of type map[string]interface{}") | ||
| // assert.NotNil(t, data, "response.Data is nil") | ||
|
|
||
| // // Check cancellation_reasons for the first order | ||
| // orders := data["orders"].([]interface{}) | ||
| // assert.Greater(t, len(orders), 0) | ||
| // cancellationReasons := orders[0].(map[string]interface{})["cancellationReasons"].([]interface{}) | ||
| // assert.Equal(t, []string{"Out of stock", "Payment failed"}, cancellationReasons) | ||
| // }) |
|
@od-hunter can you attend to the above requests? |
|
@sundayonah are you taking this ticket over the finish line. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.
Description
I updated GetLockPaymentOrders controller to include cancellation reasons in response
I updated GetLockPaymentOrderByID controller to include cancellation reasons in response
References
closes #400
Testing
Checklist
main