feat(soft-delete): implement soft delete for PaymentOrder and LockPay… #409
Conversation
…mentOrder - Created SoftDeleteMixin in schema/mixins.go following Ent documentation for soft delete. - Added SoftDeleteMixin to LockPaymentOrder and PaymentOrder schemas. - Updated PaymentOrder edge in SenderProfile to use entsql.Cascade for proper deletion handling. - Added SkipSoftDelete context utility function to conditionally bypass soft delete logic.
Fidel-wole
requested review from
chibie,
5ran6 and
OnahProsperity
as code owners
|
@Fidel-wole Please edit your PR description so that issue #407 is not closed. |
|
@Fidel-wole thanks for the PR, could you resolve the issue with the issue that the PR is closing. |
Ok will do that |
| type SoftDeleteMixin struct { | ||
| mixin.Schema | ||
| } | ||
|
|
||
| // Fields of the SoftDeleteMixin. | ||
| func (SoftDeleteMixin) Fields() []ent.Field { | ||
| return []ent.Field{ | ||
| field.Time("deleted_at"). | ||
| Optional(). | ||
| Nillable(), | ||
| } | ||
| } |
There was a problem hiding this comment.
can you copy all the mixin code that's here? https://entgo.io/docs/interceptors/#soft-delete
the only change should be "delete_time" to "deleted_at"
There was a problem hiding this comment.
I keep getting this error, do you know of a way around it?
There was a problem hiding this comment.
@Fidel-wole can you ask under "Aggregator" topic in the dev community https://t.me/+Stx-wLOdj49iNDM0
|
|
||
| type contextKey string | ||
|
|
||
| const skipSoftDeleteKey contextKey = "skipSoftDelete" | ||
|
|
||
| // SkipSoftDelete adds a context value to skip soft delete logic. | ||
| func SkipSoftDelete(ctx context.Context) context.Context { | ||
| return context.WithValue(ctx, skipSoftDeleteKey, true) | ||
| } | ||
|
|
||
| // IsSkipSoftDelete returns true if the context indicates that soft delete should be skipped. | ||
| func IsSkipSoftDelete(ctx context.Context) bool { | ||
| val := ctx.Value(skipSoftDeleteKey) | ||
| if val != nil { | ||
| return val.(bool) | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
these aren't needed... SkipSoftDelete is already be in the mixin.go snippet from ent docs
Soft Delete Implementation for PaymentOrder
Summary
Description
This PR introduces soft delete functionality for PaymentOrder and LockPaymentOrder, ensuring that deleted records are retained while being excluded from queries. The update aligns with Ent’s recommended approach, enhancing data integrity and traceability.
Key changes and rationale:
Soft delete implementation: Prevents permanent loss of data while allowing safe deletions.
Cascade deletion fix: Ensures dependent entities in SenderProfile are correctly handled.
Bypass option: Introduces SkipSoftDelete to enable scenarios where soft delete logic should be skipped (e.g., admin overrides).
These changes improve system reliability and maintainability without introducing breaking changes.
References
Closes #401
By submitting this PR, I acknowledge and agree to Paycrest’s Contributor Code of Conduct and Contribution Guide.