Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create CODEOWNERS and update template #58

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Atanda1
Copy link
Contributor

@Atanda1 Atanda1 commented Jan 28, 2025

Description

This pull request includes updates to the code ownership and pull request template files. The changes aim to clarify the default reviewers for the repository and improve the pull request submission process.

Updates to code ownership:

  • Added default code owners for the entire repository in the .github/CODEOWNERS file. ([.github/CODEOWNERSR1-R5](https://github.com/paycrest/contracts/pull/58/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R1-R5))

Improvements to pull request template:

  • Removed the code of conduct and contribution guidelines notice from the beginning of the .github/PULL_REQUEST_TEMPLATE.md file. ([.github/PULL_REQUEST_TEMPLATE.mdL1-L2](https://github.com/paycrest/contracts/pull/58/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35L1-L2))
  • Updated the references section to include an example of related pull requests/issues from other repositories. ([.github/PULL_REQUEST_TEMPLATE.mdL17-R15](https://github.com/paycrest/contracts/pull/58/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35L17-R15))
  • Re-added the code of conduct and contribution guidelines notice to the end of the .github/PULL_REQUEST_TEMPLATE.md file. ([.github/PULL_REQUEST_TEMPLATE.mdR34-R36](https://github.com/paycrest/contracts/pull/58/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35R34-R36))

References

.github/CODEOWNERS
.github/PULL_REQUEST_TEMPLATE.md

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Atanda1 Atanda1 changed the title Create CODEOWNERS fix: Create CODEOWNERS and update template Jan 30, 2025
- [ ] The correct base branch is being used, if not `master`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of not main



By submitting a PR to this repository, you agree to the terms within the [Paycrest Code of Conduct](https://paycrest.notion.site/Contributor-Code-of-Conduct-1602482d45a2806bab75fd314b381f4c). Please see the [contributing guidelines](https://paycrest.notion.site/Contribution-Guide-1602482d45a2809a8930e6ad565c906a?pvs=4) for how to create and submit a high-quality PR for this repo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the cause in aggregator repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants