Propagate error if the fs read for ohttp keys fails during config

payjoin · Dec 9, 2024 · ae95d17 · ae95d17
1 parent ad3f686
commit ae95d17
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/payjoin-cli/src/app/config.rs b/payjoin-cli/src/app/config.rs
@@ -92,27 +92,24 @@ impl AppConfig {
                     )?
                 };
 
+                #[cfg(feature = "v2")]
+                let ohttp_keys = matches
+                    .get_one::<String>("ohttp_keys")
+                    .map(|s| std::fs::read(s))
+                    .transpose()
+                    .map_err(|e| {
+                        log::error!("Failed to read ohttp_keys file: {}", e);
+                        ConfigError::Message(format!("Failed to read ohttp_keys file: {}", e))
+                    })?;
+
                 #[cfg(feature = "v2")]
                 let builder = {
                     builder
                         .set_override_option(
                             "pj_directory",
                             matches.get_one::<Url>("pj_directory").map(|s| s.as_str()),
                         )?
-                        .set_override_option(
-                            "ohttp_keys",
-                            matches.get_one::<String>("ohttp_keys").and_then(|s| {
-                                std::fs::read(s)
-                                    .map_err(|e| {
-                                        log::error!("Failed to read ohttp_keys file: {}", e);
-                                        ConfigError::Message(format!(
-                                            "Failed to read ohttp_keys file: {}",
-                                            e
-                                        ))
-                                    })
-                                    .ok()
-                            }),
-                        )?
+                        .set_override_option("ohttp_keys", ohttp_keys)
                 };
 
                 let max_fee_rate = matches