Uniform argument creation #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGould
requested changes
Nov 19, 2023
|
@arthurmelton thanks a ton for your first contribution to this repository! I realized my issue wasn't quite as clear as it could be, so I went ahead and changed it based on what I was looking for. I'll merge both commits so that we maintain a record of your help. Thanks for the efforts 😎 (just awaiting msrv fix to merge) |
DanGould
force-pushed
the
uniform_arg_declaration
branch
from
bacd690 to
4dd5cc0
Compare
|
You are all good, I was updating my laptop and was getting in an error hell. I was hoping to get it working soon but currently it's still having its problems. So don't worry about having to update a little bit of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made to fix #116 and remove the
arg!macro as a whole.