Code polish

paynl · Jun 2, 2021 · cbc278b · cbc278b
1 parent f08f8b0
commit cbc278b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/Controller/Checkout/Exchange.php b/Controller/Checkout/Exchange.php
@@ -174,15 +174,13 @@ public function execute()
         $payment = $order->getPayment();
         $info = $payment->getAdditionalInformation();
         if (!empty($info['transactionId'])) {
-            if($info['transactionId'] != $payOrderId) {
-                $this->logger->critical('transaction not equal');
+            if ($info['transactionId'] != $payOrderId) {
+                $this->logger->critical('Transaction not equal');
                 return $this->result->setContents('FALSE| Cannot load order');
-            } else {
-                $this->logger->debug('transactions match!');
             }
         } else {
-            $this->logger->critical('transaction not set in order');
-            return $this->result->setContents('TRUE| Failed. transaction not set.');
+            $this->logger->critical('Transaction not set in order');
+            return $this->result->setContents('TRUE| Failed. Transaction not set.');
         }
 
         if ($order->getTotalDue() <= 0) {
@@ -196,7 +194,7 @@ public function execute()
                 return $this->result->setContents('TRUE| Already captured.');
             }
         }
-
+        
         if ($transaction->isPaid() || $transaction->isAuthorized()) {
             return $this->processPaidOrder($transaction, $order);
         } elseif ($transaction->isCanceled()) {

diff --git a/Controller/Checkout/Finish.php b/Controller/Checkout/Finish.php
@@ -99,7 +99,7 @@ public function execute()
         $bDenied = $orderStatusId === Config::ORDERSTATUS_DENIED;
         $pinStatus = null;
         $pinCanceled = null;
-
+        
         try {
             $this->checkEmpty($payOrderId, 'payOrderid', 101);
             $this->checkEmpty($magOrderId, 'magOrderId', 1012);
@@ -114,7 +114,6 @@ public function execute()
 
             if (!empty($information['terminal_hash'])) {
                 $status = \Paynl\Instore::status(['hash' => $information['terminal_hash']]);
-                $this->logger->debug($status->getTransactionState(), $params);
                 $pinStatus = $status->getTransactionState();
                 $pinCanceled = false;
                 if (in_array($pinStatus, ['cancelled', 'expired', 'error'])) {