Skip to content

Commit

Permalink
PipeCommand: pass shell arg to ExternalCommand.
Browse files Browse the repository at this point in the history
Prior to this branch, `shell=True` was passed to Popen regardless of
whether `--shell` was passed. I'm not sure why this was the case but it
wasn't a problem. Now that we're passing to ExternalCommand, this
doesn't work because ExternalCommand does it's own manipulation of cmd
when shell=False which is incompatible with a list-style cmd.
  • Loading branch information
ryneeverett committed Dec 12, 2024
1 parent d1a0480 commit 8b9715c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion alot/commands/thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ def callback(out):

await ui.apply_command(ExternalCommand(cmd,
stdin=mail,
shell=True,
shell=self.shell,

Check warning on line 804 in alot/commands/thread.py

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

alot/commands/thread.py#L804

Function call with shell=True parameter identified, possible security issue.
thread=self.background,
on_success=callback))

Expand Down

0 comments on commit 8b9715c

Please sign in to comment.