Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about Naman. #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add info about Naman. #19

wants to merge 1 commit into from

Conversation

namanpreetsingh
Copy link

@namanpreetsingh namanpreetsingh commented Oct 12, 2017 •
edited
Loading

Add about Naman.

@namanpreetsingh namanpreetsingh changed the title Namanpreetsingh Add info about Naman. Oct 12, 2017
divyam3897
divyam3897 requested changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@divyam3897 divyam3897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty lines and squash commits into one.

@namanpreetsingh namanpreetsingh force-pushed the namanpreetsingh branch 5 times, most recently from 59d1d63 to 1da85c0 Compare October 12, 2017 13:48
divyam3897
divyam3897 requested changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@divyam3897 divyam3897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contact info not on seperate lines.

divyam3897
divyam3897 reviewed Oct 12, 2017
View reviewed changes
Copy link
Contributor

@divyam3897 divyam3897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use shortcuts like info, make a complete english sentence.

ankurbhatia24 pushed a commit to ankurbhatia24/Hacktoberfest-2k17 that referenced this pull request Oct 17, 2017
@mishal23
Merge pull request #339 from shushantkumar/master
6eb8726 
pclubuiet#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyam3897 divyam3897 divyam3897 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namanpreetsingh @divyam3897