Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1 #15

Closed
wants to merge 1 commit into from
Closed

Fixes #1 #15

wants to merge 1 commit into from

Conversation

ashwani99
Copy link
Contributor

Change the background image as the PCLUB logo and center the background image.

@ashwani99
home.html: Change background image to PCLUB logo
96f1a4c 
Change the background image as the PCLUB logo and center the background image.
divyam3897
divyam3897 requested changes Sep 30, 2017
View reviewed changes
Copy link
Contributor

@divyam3897 divyam3897 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of the logo is too big (almost toughing the navbar). It has to be fixed, the background image i.e the image behind text is blurred which is to be changed.

@ashwani99
Copy link
Contributor Author

@divyam3897 The image is only of size 600x400 pixels. Shouldn't we use a SVG file if available?

@divyam3897
Copy link
Contributor

We are still experimenting with the logo, feel free to design one if you really want to and we can review :)

@divyam3897
Copy link
Contributor

Closing this, as #77 should be the expected result now.

@divyam3897 divyam3897 closed this Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyam3897 divyam3897 divyam3897 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwani99 @divyam3897