Skip to content

Commit

Permalink
Show the built CLI's version on Windows too
Browse files Browse the repository at this point in the history
We have to do this in a Bash shell, since in the cmd shell Qt will
show the version in a message box (which is, debatably, poor Qt
behaviour; eg https://bugreports.qt.io/browse/QTBUG-114530).
  • Loading branch information
pcolby committed Nov 16, 2023
1 parent 0b76385 commit 98b8e7b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,12 @@ jobs:
copy /v /b src\cli\dokit.exe /b portable
cd portable
windeployqt --compiler-runtime --release --verbose 2 dokit.exe ${{ matrix.dll }}
:: dokit.exe --version
:: dokit.exe --version # This would hang the job, because Qt will show a message box.
working-directory: ${{ runner.temp }}
- name: Check portable
if: matrix.arch != 'arm64'
shell: bash
run: "$RUNNER_TEMP/portable/dokit.exe" --version
- name: Setup artifacts
shell: bash
run: echo "dokitVersion=$(cat "$RUNNER_TEMP/version.txt")" >> $GITHUB_ENV
Expand Down

0 comments on commit 98b8e7b

Please sign in to comment.