Skip to content

Commit

Permalink
Use the latest MSVS earlier than 14.38 for Qt5
Browse files Browse the repository at this point in the history
Because MSVC 14.38 has many issues with Qt5, and 14.29 is now the
next-latest MSVC on GitHub hosted runners (win22 20240304.2.1).

https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md
  • Loading branch information
pcolby committed Mar 12, 2024
1 parent eecde34 commit bd84986
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ jobs:
uses: ilammy/msvc-dev-cmd@v1
with:
arch: ${{ matrix.msvcArch }}
#toolset: ${{ startsWith(matrix.qt, '5') && '14.37' || '' }} # MSVC 14.38+ has many deprecation issues with Qt5.
toolset: ${{ startsWith(matrix.qt, '5') && '14.29' || '' }} # MSVC 14.38+ has many deprecation issues with Qt5.
- name: Build
env:
PROJECT_BUILD_ID: ${{ github.run_number }}.win.${{ matrix.arch }}.${{ matrix.tool }}.qt-${{ matrix.qt }}
Expand Down

0 comments on commit bd84986

Please sign in to comment.