Skip more unsafe tests on GitHhub Action's macOS 14 runners

pcolby · Apr 23, 2024 · f8faae2 · f8faae2
1 parent 4d993ab
commit f8faae2
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/test/unit/cli/testdsocommand.cpp b/test/unit/cli/testdsocommand.cpp
@@ -492,6 +492,10 @@ void TestDsoCommand::outputSamples_data()
 
 void TestDsoCommand::outputSamples()
 {
+    if (gitHubActionsRunnerOsVersion() >= QOperatingSystemVersion(QOperatingSystemVersion::MacOS, 14)) {
+        QSKIP("BLE controller operations hang on GitHub Actions's macOS 14 runners");
+    }
+
     QFETCH(DsoService::Metadata, metadata);
     QFETCH(QList<DsoService::Samples>, samplesList);
     QFETCH(AbstractCommand::OutputFormat, format);

diff --git a/test/unit/cli/teststatuscommand.cpp b/test/unit/cli/teststatuscommand.cpp
@@ -103,6 +103,10 @@ void TestStatusCommand::outputDeviceStatus_data()
 
 void TestStatusCommand::outputDeviceStatus()
 {
+    if (gitHubActionsRunnerOsVersion() >= QOperatingSystemVersion(QOperatingSystemVersion::MacOS, 14)) {
+        QSKIP("BLE controller operations hang on GitHub Actions's macOS 14 runners");
+    }
+
     QFETCH(StatusService::DeviceCharacteristics, chrs);
     QFETCH(AbstractCommand::OutputFormat, format);
     LOADTESTDATA(expected);

diff --git a/test/unit/lib/testabstractpokitservice.cpp b/test/unit/lib/testabstractpokitservice.cpp
@@ -93,6 +93,10 @@ void TestAbstractPokitService::createServiceObject()
 
 void TestAbstractPokitService::getCharacteristic()
 {
+    if (gitHubActionsRunnerOsVersion() >= QOperatingSystemVersion(QOperatingSystemVersion::MacOS, 14)) {
+        QSKIP("BLE controller operations hang on GitHub Actions's macOS 14 runners");
+    }
+
     {   // Verify an invalid characteristic is returned safely, when no controller is set.
         MockPokitService service(nullptr);
         const QLowEnergyCharacteristic characteristic = service.d_ptr->getCharacteristic(QUuid::createUuid());

diff --git a/test/unit/lib/testpokitdevice.cpp b/test/unit/lib/testpokitdevice.cpp
@@ -212,6 +212,10 @@ void TestPokitDevice::setController()
 
 void TestPokitDevice::connected()
 {
+    if (gitHubActionsRunnerOsVersion() >= QOperatingSystemVersion(QOperatingSystemVersion::MacOS, 14)) {
+        QSKIP("BLE controller operations hang on GitHub Actions's macOS 14 runners");
+    }
+
     // Verify safe error handling (can't do much else without a Bluetooth device).
     PokitDevice device(nullptr);
     QTest::ignoreMessage(QtCriticalMsg,

diff --git a/test/unit/lib/testpokitproducts.cpp b/test/unit/lib/testpokitproducts.cpp
@@ -165,6 +165,10 @@ void TestPokitProducts::pokitProduct_Controller_data()
 
 void TestPokitProducts::pokitProduct_Controller()
 {
+    if (gitHubActionsRunnerOsVersion() >= QOperatingSystemVersion(QOperatingSystemVersion::MacOS, 14)) {
+        QSKIP("BLE controller operations hang on GitHub Actions's macOS 14 runners");
+    }
+
     QFETCH(QBluetoothUuid, uuid);
     QFETCH(PokitProduct, expected);