-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #438, atomic pdi_deactivate.h, allows disabling PDI's operation while maintaining valid syntax #504
base: main
Are you sure you want to change the base?
Conversation
…do : Fortran equivalent
…deactivation mention to pull_request_template.md
|
||
#define PDI_H_ | ||
|
||
#include <paraconf.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove this paraconf
dependency?
global_size[0] = longval; | ||
PC_int(PC_get(conf, ".global_size.width"), &longval); | ||
global_size[1] = longval; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put to test all PDI functions?
global_size: { height: 60, width: 12 } | ||
|
||
pdi: | ||
plugins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you put hdf5 plugins here, to follow the case where PDI was enabled and did output. Also we can be sure from the test that the plugin is not triggered in the no-pdi case.
@@ -199,6 +199,7 @@ install(TARGETS PDI_C EXPORT PDI_C_EXPORT | |||
) | |||
install(FILES | |||
"${PDI_SOURCE_DIR}/include/pdi.h" | |||
"${PDI_SOURCE_DIR}/include/pdi_deactivation.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we discussed, put the file under no-pdi/include/pdi.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best for the end user if deactivating PDI requires the least changes.
With that idea in mind, the deactivated PDI header should be named pdi.h
.
Also, another CMake should probably be included.
100% agreed, I think the use-case is for the user to copy this file in their own repository so that they don't require an actual installation of PDI anymore. On the CMake side, we have to find a solution that works for this use-case too. |
Fix #438, atomic pdi_deactivate.h. Add a new header file which allows disabling PDI's operation, while maintaining valid syntax, and not modifying existing code.
List of things to check before making a PR
Before merging your code, please check the following:
Modify pdi/CHANGELOG.md.
Added pdi/tests/test_06.
No dependencies change.
Atomic as feature.
.clang-format
;Not applicable.
Currently 2015-2021 on pdi.h, changed to 2024 on pdi_deactivation.h only
Julian Auriac as maintainer.
Modified pdi/pdi/docs/Using_PDI.md.
Fix Provide a mechanism to deactivate PDI on demand #438.
Fix #issue
keyword to autoclose the issue when merged.