Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55 pdi packages fail to build on jammy trixie #529

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

jmorice91
Copy link
Contributor

!!!INSERT YOUR DESCRIPTION HERE!!!

List of things to check before making a PR

Before merging your code, please check the following:

  • [ x] you have added a line describing your changes to the Changelog;
  • [ x] you have added unit tests for any new or improved feature;
  • [ x] In case you updated dependencies, you have checked pdi/docs/CheckList.md
  • you have checked your code format:
    • [ x] you have checked that you respect all conventions specified in CONTRIBUTING.md;
    • [ x] you have checked that the indentation and formatting conforms to the .clang-format;
    • [ x] you have documented with doxygen any new or changed function / class;
  • you have correctly updated the copyright headers:
    • [ x] your institution is in the copyright header of every file you (substantially) modified;
    • [ x] you have checked that the end-year of the copyright there is the current one;
  • you have updated the AUTHORS file:
    • [ x] you have added yourself to the AUTHORS file;
    • [ x] if this is a new contribution, you have added it to the AUTHORS file;
  • you have added everything to the user documentation:
    • [ x] any new CMake configuration option;
    • [ x] any change in the yaml config;
    • [ x] any change to the public or plugin API;
    • [ x] any other new or changed user-facing feature;
    • [ x] any change to the dependencies;
  • you have correctly linked your MR to one or more issues:
    • [ x] your MR solves an identified issue;
    • [ x] your commit contain the Fix #issue keyword to autoclose the issue when merged.

@jmorice91 jmorice91 linked an issue Jan 31, 2025 that may be closed by this pull request
@jmorice91 jmorice91 self-assigned this Jan 31, 2025
Copy link
Member

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only asking for a tiny change :)

@jbigot
Copy link
Member

jbigot commented Feb 3, 2025

This is a great fix! Can you rebase it on top of v1.8 so that we can publish a bugfix release. Could you also add an issue about adding a test for sequential hdf5

Yushan-Wang
Yushan-Wang previously approved these changes Feb 3, 2025
@jbigot
Copy link
Member

jbigot commented Feb 3, 2025

you have updated the AUTHORS file:

[ x] you have added yourself to the AUTHORS file;
[ x] if this is a new contribution, you have added it to the AUTHORS file

Have you?

benoitmartin88
benoitmartin88 previously approved these changes Feb 4, 2025
Copy link
Member

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmorice91
Copy link
Contributor Author

jmorice91 commented Feb 4, 2025

This is a great fix! Can you rebase it on top of v1.8 so that we can publish a bugfix release. Could you also add an issue about adding a test for sequential hdf5

The merge of "#502" introduce this bug in the main repo. This pull request is not merged yet in v.1.8.1. So there is no bugfix release.

For adding tests on sequential hdf5, the issue #530 is created

@jbigot
Copy link
Member

jbigot commented Feb 4, 2025

Sorry, my bad, I didn't realize. Then if this is a fix for something that didn't make it to any release, it shouldn't be listed in the changelog. This is transparent for our users

@jbigot
Copy link
Member

jbigot commented Feb 4, 2025

However, it would be nice to add the contribution to the authors file.

JAuriac
JAuriac previously approved these changes Feb 5, 2025
@jmorice91
Copy link
Contributor Author

I added a comment for this issue in AUTHORS

@jmorice91 jmorice91 requested a review from JAuriac February 5, 2025 10:11
Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks 🙏

@jmorice91 jmorice91 merged commit 6414b8a into main Feb 5, 2025
34 checks passed
@jmorice91 jmorice91 deleted the 55-pdi-packages-fail-to-build-on-jammy-trixie branch February 5, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDI packages fail to build on jammy & trixie
5 participants