-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 pdi packages fail to build on jammy trixie #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only asking for a tiny change :)
Co-authored-by: Benoit Martin <[email protected]>
This is a great fix! Can you rebase it on top of v1.8 so that we can publish a bugfix release. Could you also add an issue about adding a test for sequential hdf5 |
Have you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The merge of "#502" introduce this bug in the main repo. This pull request is not merged yet in v.1.8.1. So there is no bugfix release. For adding tests on sequential hdf5, the issue #530 is created |
Sorry, my bad, I didn't realize. Then if this is a fix for something that didn't make it to any release, it shouldn't be listed in the changelog. This is transparent for our users |
0e53060
However, it would be nice to add the contribution to the authors file. |
I added a comment for this issue in AUTHORS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks 🙏
!!!INSERT YOUR DESCRIPTION HERE!!!
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format
;Fix #issue
keyword to autoclose the issue when merged.